Plugin system for projectpier

Project:ProjectPier
Version:0.8.0.2
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:patch - code needs work
Description

We have modified the initial plugin system developed by activeingredient to be able to locate the file plugins in a separate directory. Attached is a patch with the modified plugin system (patch against current trunk - rev 159).

The patch implements a plugin directory (application/plugins) in which resides the plugin files.

Attached you can also find the wiki plugin developed by Alex Mayhew, you need to rename wiki_plugin.patch to wiki_plugin.tgz and put its output in applications/plugins.

Each plugin has its own directory where it can place controllers, models and views. See wiki plugin for more information.
Also, in applications/plugins/ are three shared directories (_language _library and _helpers) where plugins place the appropiate files. (we should change that allowing all plugin files to be in a separate dir).

We have make some other necessary changes :

- Plugin manager now asks if you want to keep or purge the plugin data.
- Dashboard have needed some changes to not show logs from uninstalled plugins.

We want to add some integration between projectpier permissions and the plugin system also in the next weeks.

Feel free to ask anything.

Regards ;)

AttachmentSize
plugin.patch17.76 KB
wiki_plugin.patch25.94 KB
Title:Plugin system for projectpier » Error in patch

This is the correct patch. Sorry ;)

AttachmentSize
plugin.patch190.72 KB
Title:Error in patch» Plugin system for projectpier

Isn't this a duplicate of this issue -> http://projectpier.org/node/847

You should be posting revised patches there. Also, you should only change the title of the issue if the issue content actually changes. Any description of the update should be made in the comment body.

cgonzalez,

It appears that you have included more functionality in this patch than just the new plugin code. I see changes to CSS files dealing with forms, task lists, etc. These don't have anything to do with enabling plugins, as far as I can tell, and shouldn't be included in the patch. Also, there are patches to the 'es_es' language, and those should be included in a separate file. The main patch should include only en_us language changes as that is the default language in SVN.

Also, as Ryan previously stated, anything related to activeingredient's initial plugin patch should be posted to that issue (Issue 847).

I do believe that the improvements you made could be useful to the plugin development, but for anyone to take a shot at reviewing the code and offering further improvements you are going to need to provide a patch file that minimize the changes (i.e., remove all the changes that are not related to the plugin code).

Can you please provide a new patch minimizing the changes, please? Remember to attach it to Issue 847, not this issue.