Remove styling markup from add_list.php
Submitted by kemie on Thu, 04/03/2008 - 17:05.
| Project: | ProjectPier |
| Version: | 0.8.5.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch - code needs review |
Description
/application/views/tasks/add_list.php contains inline styles that make it hard to style with themes.
Sorry i tried to create a patch, but I'm useless with svn.
Basically, the proposed fix is to take line #55
and replace with
I'm attaching a patch file, but i'm not sure it's working. the fix works, the patch file is untested.
| Attachment | Size |
|---|---|
| add_list.patch | 417 bytes |
ugh, cannot edit, but meant replace
<tr style="background: <?php echo $i % 2 ? '#fff' : '#e8e8e8' ?>">with
<tr class="<?php echo $i % 2 ? 'odd' : 'even' ?>">The patch includes your full directory structure.
I'll try to get to it, try your modification and create the according patch but if anybody feels like it before me, feel free :)
I haven't changed anything to your suggestion. The patch should work on all installations though.
One task that comes with this patch is to possibly update the themes to use that.
It does work without modification to the themes.
Thanks Tim. marine & sand themes already work with it, and it would be super simple to add support to other themes. what's the best way to go about it? submit individual patches or one mega-patch?
Individual patches help us track things better, but if you'd like to also supply a mega patch with a reference to the other patches that's helpful too =)