Class called acInstallation refering to activeCollab
Submitted by Tim on Tue, 03/11/2008 - 01:34.
| Project: | ProjectPier |
| Version: | 0.8.5.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | minor |
| Assigned: | Tim |
| Status: | patch - code needs review |
Description
In the installation steps, a class is called acInstallation where it should now be ppInstallation most probably.
Additionally, some constants are called API_CONSTANT where PPI_CONSTANT would make more sense...
Here is a patch that corrects different names from ac-something to pp-something.
It also changes the file acInstallation.class.php for ppInstallation.class.php.
So, during the review, it should probably compare the new file with the old file ;-)
Can be committed pretty fast. Thanks!
2 quick comments:
1 - I do want to strip out references to aC, but I think it might be better to just not have references. i.e. acInstallation -> installation
2 - API is correct is stands for Application Programming Interface, not acSomething.
ok I'll make another patch that removes the reference to ProjectPier too.
However, I made a typo in my initial post and it is ACI_CONSTANT probably meaning activeCollab Installation...
I'll post a new patch later on
Tim
Ok, so here is the new patch.
It changes the constant ACI_SOMETHING to INSTALL_SOMETHING, acInstallation.class.php to Installation.class.php and installation.php to main_installation.php to avoid confusions.
And some other stuff here and there.
FYI, I copy below the differences between acInstallation.class.php and Installation.class.php as well as between installation.php and main_installation.php. I couldn't get SVN to make something clean out of the renaming...
Index: public/install/installation/Installation.class.php
===================================================================
--- public/install/installation/Installation.class.php (revision 161)
+++ public/install/installation/Installation.class.php (working copy)
@@ -1,6 +1,6 @@
<?php - final class acInstallation {
+ final class Installation {
/**
* Output object
@@ -69,7 +69,7 @@
* Constructor
*
* @param Output $output
- * @return acInstallation
+ * @return Installation
*/
function __construct(Output $output) {
$this->setOutput($output);
@@ -448,6 +448,6 @@
$this->absolute_url = $value;
} // setAbsoluteUrl
- } // acInstallation
+ } // Installation
?>Index: public/install/installation/main_installation.php
===================================================================
--- public/install/installation/main_installation.php (revision 161)
+++ public/install/installation/main_installation.php (working copy)
@@ -4,7 +4,7 @@
* Main installation file. Load specific steps and prepare the installation
*
* @package ScriptInstaller
- * @subpackage AC installation
+ * @subpackage ProjectPier installation
* @version 1.0
* @http://www.projectpier.org/
*/
@@ -19,9 +19,9 @@
$installer = new ScriptInstaller('ProjectPier installation', 'This wizard will guide you through the ProjectPier installation process');
// Add steps
- define('ACI_WELCOME', $installer->addStep(new WelcomeStep()));
- define('ACI_CHECKS', $installer->addStep(new ChecksStep()));
- define('ACI_SYSTEM_CONFIG', $installer->addStep(new SystemConfigStep()));
- define('ACI_FINISH', $installer->addStep(new FinishStep()));
+ define('INSTALL_WELCOME', $installer->addStep(new WelcomeStep()));
+ define('INSTALL_CHECKS', $installer->addStep(new ChecksStep()));
+ define('INSTALL_SYSTEM_CONFIG', $installer->addStep(new SystemConfigStep()));
+ define('INSTALL_FINISH', $installer->addStep(new FinishStep()));
?>